Hi Krzysztof,

On Fri, Feb 10, 2023 at 11:59 AM Krzysztof Kozlowski
[off-list ref] wrote:

On 10/02/2023 07:56, Sergio Paracuellos wrote:

quoted

MT7621 SoC provides a system controller node for accessing to some registers.
Add a phandle to this node to avoid using MIPS related arch operations and

I don't understand this part. You claim you add a phandle to this node,
but your binding suggest you add here a phandle to other node.

Probably my English is not the best here :-). Yes, you are right, I
just want to add a phandle to the 'sysc' node in the current node.

quoted

includes in watchdog driver code.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 .../bindings/watchdog/mediatek,mt7621-wdt.yaml       | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
index b2b17fdf4..3c545065f 100644
--- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml

@@ -14,11 +14,18 @@ allOf:

 properties:
   compatible:
-    const: mediatek,mt7621-wdt
+    items:
+      - const: mediatek,mt7621-wdt
+      - const: syscon

   reg:
     maxItems: 1

+  ralink,sysctl:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      phandle of syscon used to control system registers

This needs to be more specific - which syscon? It also does not fit your
commit msg.

Sure. How about "phandle to system controller 'sysc' syscon node which
controls system registers".

Best regards,
Krzysztof

Thanks,
    Sergio Paracuellos