Re: [PATCH 1/3] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
From: Krzysztof Kozlowski <hidden>
Date: 2023-02-10 11:00:40
Also in:
linux-mips, linux-watchdog, lkml
On 10/02/2023 07:56, Sergio Paracuellos wrote:
MT7621 SoC provides a system controller node for accessing to some registers. Add a phandle to this node to avoid using MIPS related arch operations and
I don't understand this part. You claim you add a phandle to this node, but your binding suggest you add here a phandle to other node.
quoted hunk ↗ jump to hunk
includes in watchdog driver code. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> --- .../bindings/watchdog/mediatek,mt7621-wdt.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml index b2b17fdf4..3c545065f 100644 --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml@@ -14,11 +14,18 @@ allOf: properties: compatible: - const: mediatek,mt7621-wdt + items: + - const: mediatek,mt7621-wdt + - const: syscon reg: maxItems: 1 + ralink,sysctl: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle of syscon used to control system registers
This needs to be more specific - which syscon? It also does not fit your commit msg. Best regards, Krzysztof