Thread (31 messages) 31 messages, 3 authors, 2022-08-04

Re: [PATCH v2 02/20] dt-bindings: power: Add power-domain header for RV1126

From: Krzysztof Kozlowski <hidden>
Date: 2022-08-03 11:39:20
Also in: linux-arm-kernel, linux-rockchip

On 03/08/2022 13:30, Jagan Teki wrote:
On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski
[off-list ref] wrote:
quoted
On 03/08/2022 12:46, Jagan Teki wrote:
quoted
On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski
[off-list ref] wrote:
quoted
On 03/08/2022 12:24, Jagan Teki wrote:
quoted
quoted
Vendor in filename is needed.
Yes this follows how similar rockchip vendor notation

$ ls include/dt-bindings/power/rk3* -l
 include/dt-bindings/power/rk3036-power.h
 include/dt-bindings/power/rk3066-power.h
 include/dt-bindings/power/rk3128-power.h
 include/dt-bindings/power/rk3188-power.h
 include/dt-bindings/power/rk3228-power.h
 include/dt-bindings/power/rk3288-power.h
 include/dt-bindings/power/rk3328-power.h
 include/dt-bindings/power/rk3366-power.h
 include/dt-bindings/power/rk3368-power.h
 include/dt-bindings/power/rk3399-power.h
 include/dt-bindings/power/rk3568-power.h

So when are we going to switch to vendor,device pattern if you keep
adding files with wrong naming?
Do you mean the above files are following the wrong naming pattern?
Yes, or at least discouraged naming. The recommended naming which I hope
all new files will follow are vendor,device.h.
rockchip-rv1126-power.h

Will this be Okay?
After vendor prefix goes coma, so rockchip,rv1126-power.h


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help