Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4

Hi Krzysztof,

On Tue, Aug 23, 2022 at 3:43 PM Krzysztof Kozlowski
[off-list ref] wrote:

On 20/08/2022 11:29, Dario Binacchi wrote:

quoted

Add pin configurations for using CAN controller on stm32f469-disco
board. They are located on the Arduino compatible connector CN5 (CAN1)
and on the extension connector CN12 (CAN2).

Signed-off-by: Dario Binacchi <redacted>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Do not ignore review. This is not correct. You are mixing copyright with
SoC...

OK. I got it. I will drop one SOB in version 3.

quoted

quoted

+                     can2_pins_b: can2-1 {
+                             pins1 {
+                                     pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
+                             };
+                             pins2 {
+                                     pinmux = <STM32_PINMUX('B', 12, AF9)>; /* CAN2_RX */
+                                     bias-pull-up;
+                             };
+                     };
+

Don't ignore review.

Sorry, I didn't want to ignore your review, I thought the blank line
to be removed was another.
Actually I had to remove two blank lines and I left out the one you suggested.

Thanks and regards,
Dario

That's second one, so that's a no.. :(

Best regards,
Krzysztof

-- 

Dario Binacchi

Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com

www.amarulasolutions.com