Re: [PATCH v2 0/6] Configurable VLAN mode for NCSI driver

From
Jakub Kicinski <kuba@kernel.org>
Date
2022-06-11 05:44:31
Also in
lkml, netdev, openbmc
Reply to
Jiaqing Zhao, 2022-06-11
On Sat, 11 Jun 2022 13:18:51 +0800 Jiaqing Zhao wrote:
All ncsi devices uses the same driver as they uses same command set,
so the driver doesn't know what modes are supported. And in current
driver, the vlan related parameters are configured when registering
the device, adding an ncsi-netlink command to do so seems to be
unsuitable.
Maybe you could draw a diagram? NC-SI is a bit confusing.
And adding a netlink command requires extra application in userspace
to switch the mode. In my opinion, it would be more user-friendly to
make it usable on boot.
Unfortunately convenience is not reason to start adding system config
into DT.
Netdev also does not work as the ncsi device itself does not have
its own netdev, the netdev comes from the mac device. For different
vlan modes, the netdev feature set of its parent mac device are the
same.
You say that, yet the command handling already takes into account the
VLAN list:

	if (list_empty(&ndp->vlan_vids)) {

which come from the MAC netdev. What's wrong with setting the filtering
mode based on NETIF_F_HW_VLAN_CTAG_FILTER ?
Thread (17 messages) 17 messages, 3 authors, last reply 2022-06-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help