Hi Andy,

On Wed, Dec 22, 2021 at 12:21:01PM +0200, Andy Shevchenko wrote:

On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin [off-list ref] wrote:

quoted

From: Liam Beguin <redacted>

In preparation for the addition of kunit tests, expose the logic
responsible for combining channel scales.

...

quoted

 #include <linux/gcd.h>
 #include <linux/iio/consumer.h>
 #include <linux/iio/iio.h>
+#include <linux/iio/afe/rescale.h>

It should go before the consumer.h, no?

I don't mind making the change, but why should it go before consumer.h?

And I would rather move the entire IIO group of headers...

I can do that too. Do we have a convention for the ordering of #includes?
What's usually the rule/guideline for this?

quoted

 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/property.h>

... somewhere here (with blank line above).

quoted

-struct rescale;

...

quoted

+#ifndef __IIO_RESCALE_H__
+#define __IIO_RESCALE_H__
+
+#include <linux/iio/iio.h>

Missed types.h and forward declarations like
struct device;

Okay. will add linux/types.h

Cheers,
Liam

-- 
With Best Regards,
Andy Shevchenko