Thread (38 messages) 38 messages, 2 authors, 2022-01-08

Re: [PATCH v11 11/15] iio: test: add basic tests for the iio-rescale driver

From: Andy Shevchenko <hidden>
Date: 2021-12-22 12:40:16
Also in: linux-iio, lkml

On Wed, Dec 22, 2021 at 5:47 AM Liam Beguin [off-list ref] wrote:
From: Liam Beguin <redacted>

The iio-rescale driver supports various combinations of scale types and
offsets. These can often result in large integer multiplications. Make
sure these calculations are done right by adding a set of kunit test
cases that build on top of iio-test-format.
...
+       int fract_mult = 100000000LL;
Perhaps also change to use the prefix?

...
+       *nano = (s64)tmp * 10 * fract_mult + tmp2;
I'm also puzzled what the meaning of the 10 is here?

...
+       err = 1000000 * abs(exp - real);
Prefix?

...
+       err = div64_u64(err, abs(exp));
+       return (int)err;
return div64_u64();

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help