Hi Andy,

On Tue, Dec 21, 2021 at 07:42:31AM +0200, Andy Shevchenko wrote:

On Mon, Dec 20, 2021 at 11:17 AM Liam Beguin [off-list ref] wrote:

quoted

From: Liam Beguin <redacted>

iio_convert_raw_to_processed_unlocked() assumes the offset is an
integer. Make a best effort to get a valid offset value for fractional
cases without breaking implicit truncations.

...

quoted

+                       offset_val /= (1 << offset_val2);

Besides potentially being problematic (if arg is 31 for the left
shift) why not simply

_val >>= _val2;

That is safer, and more elegant! I'll update.

Thanks,
Liam

--
With Best Regards,
Andy Shevchenko