Thread (21 messages) 21 messages, 4 authors, 2021-12-22

Re: [PATCH v10 03/14] iio: inkern: make a best effort on offset calculation

From: Andy Shevchenko <hidden>
Date: 2021-12-21 05:43:11
Also in: linux-iio, lkml

On Mon, Dec 20, 2021 at 11:17 AM Liam Beguin [off-list ref] wrote:
From: Liam Beguin <redacted>

iio_convert_raw_to_processed_unlocked() assumes the offset is an
integer. Make a best effort to get a valid offset value for fractional
cases without breaking implicit truncations.
...
+                       offset_val /= (1 << offset_val2);
Besides potentially being problematic (if arg is 31 for the left
shift) why not simply

_val >>= _val2;

?

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help