Re: [PATCH v2 2/3] dt-bindings: mmc: Add bindings for LiteSDCard
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-12-06 09:39:52
Also in:
linux-mmc, lkml
Hi Gabriel, (whoops, I did intend to reply to v2, let's duplicate) On Sat, Dec 4, 2021 at 9:41 PM Gabriel Somlo [off-list ref] wrote:
LiteSDCard is a small footprint, configurable SDCard core for FPGA based system on chips. Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/Documentation/devicetree/bindings/mmc/litex,mmc.yaml@@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mmc/litex,mmc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LiteX LiteSDCard device + +maintainers: + - Gabriel Somlo <gsomlo@gmail.com> + +description: | + LiteSDCard is a small footprint, configurable SDCard core for FPGA based + system on chips. + + The hardware source is Open Source and can be found on at + https://github.com/enjoy-digital/litesdcard/. + +allOf: + - $ref: mmc-controller.yaml# + +properties: + compatible: + const: litex,mmc + + reg: + items: + - description: PHY registers + - description: CORE registers + - description: DMA Reader buffer + - description: DMA Writer buffer + - description: IRQ registers + + reg-names: + items: + - const: phy + - const: core + - const: reader + - const: writer + - const: irq + + interrupts: + maxItems: 1 + +required: + - compatible + - reg
reg-names? (and updating litex/tools/litex_json2dts_linux.py to add it)
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ mmc: mmc@12005000 {
+ compatible = "litex,mmc";
+ reg = <0x12005000 0x100>,
+ <0x12003800 0x100>,
+ <0x12003000 0x100>,
+ <0x12004800 0x100>,
+ <0x12004000 0x100>;
+ reg-names = "phy", "core", "reader", "writer", "irq";
+ interrupts = <4>;
+ };
The rest looks good to me, so
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds