Thread (12 messages) 12 messages, 4 authors, 2021-11-01

Re: [PATCH v5 4/5] pinctrl: add pinctrl/GPIO driver for Apple SoCs

From: Andy Shevchenko <hidden>
Date: 2021-11-01 19:23:22
Also in: linux-gpio

On Mon, Nov 1, 2021 at 7:53 PM Joey Gouly [off-list ref] wrote:
On Sun, Oct 31, 2021 at 03:39:01PM +0200, Andy Shevchenko wrote:
quoted
On Wed, Oct 27, 2021 at 5:28 AM Joey Gouly [off-list ref] wrote:
...
quoted
quoted
+       ret = of_property_count_u32_elems(node, "pinmux");
+       if (ret <= 0) {
+               dev_err(pctl->dev,
+                       "missing or empty pinmux property in node %pOFn.\n",
+                       node);
+               return ret;
if (ret == 0)
 dev_err();
 return 0;
quoted
This is incorrect. It always happens when somebody is in hurry :-)
I don't understand which bit you are saying is incorrect here, can you expand on your comment?
See above.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help