Hi Andy,

On Sun, Oct 31, 2021 at 03:39:01PM +0200, Andy Shevchenko wrote:

On Wed, Oct 27, 2021 at 5:28 AM Joey Gouly [off-list ref] wrote:

quoted

This driver adds support for the pinctrl / GPIO hardware found
on some Apple SoCs.

...

quoted

+       ret = of_property_count_u32_elems(node, "pinmux");
+       if (ret <= 0) {
+               dev_err(pctl->dev,
+                       "missing or empty pinmux property in node %pOFn.\n",
+                       node);
+               return ret;

This is incorrect. It always happens when somebody is in hurry :-)

I don't understand which bit you are saying is incorrect here, can you expand on your comment?

[...]

Thanks for the other comments, I'll prepare a patch addressing it soon.

Thanks,
Joey