Thread (34 messages) 34 messages, 6 authors, 2021-11-23

Re: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series

From: Jesse Taube <hidden>
Date: 2021-11-02 23:25:58
Also in: linux-arm-kernel, linux-clk, linux-gpio, linux-mmc, linux-serial, lkml


On 11/2/21 19:17, Fabio Estevam wrote:
On Tue, Nov 2, 2021 at 7:57 PM Jesse Taube [off-list ref] wrote:
quoted
  static struct esdhc_soc_data usdhc_imx8qxp_data = {
         .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
@@ -357,6 +363,7 @@ static const struct of_device_id imx_esdhc_dt_ids[] = {
         { .compatible = "fsl,imx7ulp-usdhc", .data = &usdhc_imx7ulp_data, },
         { .compatible = "fsl,imx8qxp-usdhc", .data = &usdhc_imx8qxp_data, },
         { .compatible = "fsl,imx8mm-usdhc", .data = &usdhc_imx8mm_data, },
+       { .compatible = "fsl,imxrt-usdhc", .data = &usdhc_imxrt_data, },
I thought Rob suggested to use the SoC name, so this would be:
Uh i think that may have been for the UART.
{ .compatible = "fsl,imxrt1050-usdhc", .data = &usdhc_imxrt1050_data, },

The same applies to the other bindings in the series.

This way it would be possible to differentiate between future
supported i.MX RT devices.
This makes sense will do in V3.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help