On Sun, Oct 17, 2021 at 7:27 PM Chanho Park [off-list ref] wrote:

quoted

quoted

+  samsung,sysreg:
+    $ref: '/schemas/types.yaml#/definitions/phandle'
+    description: phandle for FSYSx sysreg interface, used to control
+                 sysreg register bit for UFS IO Coherency
+
+  samsung,ufs-shareability-reg-offset:
+    $ref: '/schemas/types.yaml#/definitions/uint32'
+    description: Offset to the shareability register for io-coherency

Make these a single property: <phandle offset>

As I already mentioned previous e-mail [1], I need to support two ufs
instances for exynosauto v9 soc.

Don't expect me to remember. That was 100s of reviews ago.

syscon_fsys2: syscon@17c20000 {
        compatible = "samsung,exynosautov9-sysreg", "syscon";
        reg = <0x17c20000 0x1000>;
};

ufs_0: ufs0@17e00000 {
        <snip>
        samsung,sysreg = <&syscon_fsys2>;
        samsung,ufs-shareability-reg-offset = <0x710>;

samsung,ufs-shareability-reg = <&syscon_fsys2 0x710>;

};

To be added ufs_1 like below
ufs_1: ufs0@17f00000 {
        <snip>
        samsung,sysreg = <&syscon_fsys2>;
        samsung,ufs-shareability-reg-offset = <0x714>;

samsung,ufs-shareability-reg = <&syscon_fsys2 0x714>;

I still don't see what's the problem?

};

[1]:
https://lore.kernel.org/linux-scsi/000901d7b0e0$e618b220$b24a1660$@samsung.c
om/

If you prefer them to be separated sysreg phandles which directly pointing
the register, I'm able to change it.
But, the syscon_fsys2 can be used for other IPs as well such as ethernet.

Best Regards,
Chanho Park