RE: [PATCH v4 13/16] dt-bindings: ufs: exynos-ufs: add io-coherency property
From: Chanho Park <hidden>
Date: 2021-10-18 11:07:17
Also in:
linux-samsung-soc, linux-scsi
quoted
quoted
+ samsung,sysreg: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: phandle for FSYSx sysreg interface, used to control + sysreg register bit for UFS IO Coherency + + samsung,ufs-shareability-reg-offset: + $ref: '/schemas/types.yaml#/definitions/uint32' + description: Offset to the shareability register for + io-coherencyMake these a single property: <phandle offset>As I already mentioned previous e-mail [1], I need to support two ufs instances for exynosauto v9 soc. syscon_fsys2: syscon@17c20000 { compatible = "samsung,exynosautov9-sysreg", "syscon"; reg = <0x17c20000 0x1000>; }; ufs_0: ufs0@17e00000 { <snip> samsung,sysreg = <&syscon_fsys2>; samsung,ufs-shareability-reg-offset = <0x710>; }; To be added ufs_1 like below ufs_1: ufs0@17f00000 { <snip> samsung,sysreg = <&syscon_fsys2>; samsung,ufs-shareability-reg-offset = <0x714>; }; [1]: https://lore.kernel.org/linux- scsi/000901d7b0e0$e618b220$b24a1660$@samsung.com/ If you prefer them to be separated sysreg phandles which directly pointing the register, I'm able to change it. But, the syscon_fsys2 can be used for other IPs as well such as ethernet.
Finally, I got your point. You want me to drop
"samsung,ufs-shareability-reg-offset" and put the offset like below.
ufs_0: ufs0@17e00000 {
<snip>
samsung,sysreg = <&syscon_fsys2 0x710>;
To be added ufs_1 like below
ufs_1: ufs0@17f00000 {
<snip>
samsung,sysreg = <&syscon_fsys2 0x714>;
I'll resend the patch with your suggestion.
Krzysztof, could you please hold below on? Or Do I need to make an
additional patch?
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=nex
t/dt64&id=31bbac5263aa63dfc8bfed2180bb6a5a3c531681
Best Regards,
Chanho Park