Re: [PATCH v4 15/20] crypto: qce: Add new compatibles for qce crypto driver

Hi Thara and Vladimir,

On Wed, 20 Oct 2021 at 19:37, Thara Gopinath [off-list ref] wrote:

On 10/13/21 6:55 AM, Bhupesh Sharma wrote:

quoted

Since we decided to use soc specific compatibles for describing
the qce crypto IP nodes in the device-trees, adapt the driver
now to handle the same.

Cc: Thara Gopinath <redacted>
Cc: Bjorn Andersson <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Bhupesh Sharma <redacted>
---
  drivers/crypto/qce/core.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index 033c7278aa5d..2ab0b97d718c 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c

@@ -298,8 +298,8 @@ static int qce_crypto_remove(struct platform_device *pdev)
  }

  static const struct of_device_id qce_crypto_of_match[] = {
-     { .compatible = "qcom,crypto-v5.1", },

Hi Bhupesh,

I think we should keep the qcom,crypto-v5.1 here for backward
compatibility. Since v5.4 was added only recently it might be okay to
remove it.

Thanks, I will fix this in the v5.

Regards,
Bhupesh

quoted

-     { .compatible = "qcom,crypto-v5.4", },
+     { .compatible = "qcom,ipq6018-qce", },
+     { .compatible = "qcom,sdm845-qce", },
      {}
  };
  MODULE_DEVICE_TABLE(of, qce_crypto_of_match);