Re: [PATCH v4 05/20] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Date: 2021-10-13 13:03:20
Also in:
linux-arm-msm, linux-crypto, lkml
Hi Bhupesh, On 10/13/21 1:55 PM, Bhupesh Sharma wrote:
quoted hunk ↗ jump to hunk
Add new optional properties - 'interconnects' and 'interconnect-names' to the device-tree binding documentation for qcom-bam DMA IP. These properties describe the interconnect path between bam and main memory and the interconnect type respectively. Cc: Thara Gopinath <redacted> Cc: Bjorn Andersson <redacted> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <redacted> --- Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml index 32b47e3b7769..602e68df971f 100644 --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml@@ -45,6 +45,14 @@ properties: const: 1 description: The single cell represents the channel index. + interconnects: + maxItems: 1 + description: |
here I have the same comment about the set literal style of the multi-line description, which is one-line, likely the specifier is not needed...
+ Interconnect path between bam and main memory.
+
+ interconnect-names:
+ const: memory
+
qcom,ee:
$ref: /schemas/types.yaml#/definitions/uint32
description:-- Best wishes, Vladimir