RE: [PATCH v6 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
From: <hidden>
Date: 2021-10-06 05:09:41
Also in:
linux-arm-msm, lkml
-----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Monday, October 4, 2021 5:51 PM To: Rakesh Pillai <redacted> Cc: mathieu.poirier@linaro.org; swboyd@chromium.org; p.zabel@pengutronix.de; devicetree@vger.kernel.org; bjorn.andersson@linaro.org; linux-kernel@vger.kernel.org; robh+dt@kernel.org; sibis@codeaurora.org; kuabhs@chromium.org; agross@kernel.org; ohad@wizery.com; linux-arm-msm@vger.kernel.org; mpubbise@codeaurora.org Subject: Re: [PATCH v6 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support On Mon, 04 Oct 2021 12:18:52 +0530, Rakesh Pillai wrote:quoted
Add WPSS PIL loading support for SC7280 SoCs. Signed-off-by: Rakesh Pillai <redacted> --- .../bindings/remoteproc/qcom,sc7280-wpss-pil.yaml | 196 +++++++++++++++++++++ 1 file changed, 196 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yamlquoted
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:interrupts: 'oneOf' conditional failed, one must
be
fixed:
[{'description': 'Watchdog interrupt'}, {'description': 'Fatalinterrupt'},
{'description': 'Ready interrupt'}, {'description': 'Handover interrupt'},
{'description': 'Stop acknowledge interrupt'}, {'description': 'Shutdown
acknowledge interrupt'}] is too long
[{'description': 'Watchdog interrupt'}, {'description': 'Fatalinterrupt'},
{'description': 'Ready interrupt'}, {'description': 'Handover interrupt'},
{'description': 'Stop acknowledge interrupt'}, {'description': 'Shutdown
acknowledge interrupt'}] is too short
False schema does not allow 6
1 was expected
6 is greater than the maximum of 2
6 is greater than the maximum of 3
6 is greater than the maximum of 4
6 is greater than the maximum of 5
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-
wpss-pil.yaml: properties:interrupt-names: 'oneOf' conditional failed, one
must be fixed:
[{'const': 'wdog'}, {'const': 'fatal'}, {'const': 'ready'},{'const':'handover'}, {'const': 'stop-ack'}, {'const': 'shutdown-ack'}] is too long
[{'const': 'wdog'}, {'const': 'fatal'}, {'const': 'ready'},{'const':'handover'}, {'const': 'stop-ack'}, {'const': 'shutdown-ack'}] is tooshort
False schema does not allow 6 1 was expected 6 is greater than the maximum of 2 6 is greater than the maximum of 3 6 is greater than the maximum of 4 6 is greater than the maximum of 5 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: [{'description': 'GCC WPSS AHB BDG Master clock'}, {'description': 'GCC WPSS AHB clock'}, {'description': 'GCC WPSS RSCP clock'},
{'description':'XO clock'}] is too long
[{'description': 'GCC WPSS AHB BDG Master clock'}, {'description':
'GCC WPSS AHB clock'}, {'description': 'GCC WPSS RSCP clock'},{'description':'XO clock'}] is too short False schema does not allow 4 1 was expected 4 is greater than the maximum of 2 4 is greater than the maximum of 3 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:clock-names: 'oneOf' conditional failed, one
must
be fixed:
[{'const': 'ahb_bdg'}, {'const': 'ahb'}, {'const': 'rscp'},{'const': 'xo'}] istoo long
[{'const': 'ahb_bdg'}, {'const': 'ahb'}, {'const': 'rscp'},{'const': 'xo'}] istoo short False schema does not allow 4 1 was expected 4 is greater than the maximum of 2 4 is greater than the maximum of 3 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:power-domains: 'oneOf' conditional failed, one must be fixed: [{'description': 'CX power domain'}, {'description': 'MX power domain'}] is too long [{'description': 'CX power domain'}, {'description': 'MX power domain'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:power-domain-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'cx'}, {'const': 'mx'}] is too long [{'const': 'cx'}, {'const': 'mx'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:resets: 'oneOf' conditional failed, one must be fixed: [{'description': 'AOSS restart'}, {'description': 'PDC SYNC'}] is
too long
[{'description': 'AOSS restart'}, {'description': 'PDC SYNC'}] istoo short
False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt- review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- wpss-pil.yaml: properties:reset-names: 'oneOf' conditional failed, one
must
be fixed:
[{'const': 'restart'}, {'const': 'pdc_sync'}] is too long
[{'const': 'restart'}, {'const': 'pdc_sync'}] is too short
False schema does not allow 2
1 was expected
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-
wpss-pil.yaml: ignoring, error in schema: properties: interrupts
warning: no schema found in file:
./Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-
pil.yaml
Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-
pil.example.dt.yaml:0:0: /example-0/remoteproc@8a00000: failed to match
any schema with compatible: ['qcom,sc7280-wpss-pil']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1535950
This check can fail if there are any dependencies. The base for a patchseries
is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above
error(s),
then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
I have updated the dtschema (2021.7) and still not seeing these errors. I will fix the errors mentioned in this log though. Is there any other flag/setting, which is to be enabled ? Thanks, Rakesh Pillai.