Re: [PATCH 6/6] memory: renesas-rpc-if: Add support for RZ/G2L

Hi Wolfram,

On Fri, Oct 1, 2021 at 1:04 PM Wolfram Sang
[off-list ref] wrote:

Hi Prabhakar,

I checked the G2L datasheet and reconsidered. It is better if your patch
goes in first. That means...

quoted

quoted

quoted

quoted

Is RPCIF_CMNCR_IO3FV and RPCIF_CMNCR_IO2FV actually documented in your
datasheets? I am asking because I have a patch pending to remove writing
to undocumented locations. So, I was aboout to remove the IO3FV and
IO2FV macros.

Yes they are documented, you should be able to download the HW manual from [1]

Great, then I will keep them!

... that you could change the comments here from "undocumented" to
"documened for G2L" or similar.

quoted

quoted

quoted

quoted

quoted

+             regmap_read(rpc->regmap, RPCIF_PHYCNT, &dummy);
+             dummy &= ~RPCIF_PHYCNT_PHYMEM_MASK;
+             dummy |= RPCIF_PHYCNT_PHYMEM(hyperflash ? 3 : 0) | 0x260;
+             regmap_write(rpc->regmap, RPCIF_PHYCNT, dummy);

regmap_update_bits?

Im a bit hesitant to use regmap_update_bits() here as some of the bits
are not documented.

Here you can keep your code as is. I will change it afterwards if needed
once I clarified all undocumented locations.

Thanks, will re-spin the patches with comments fixed.

Thanks and have a nice weekend,

You too.

Cheers,
Prabhakar

   Wolfram