Hi Wolfram,

On Fri, Oct 1, 2021 at 9:55 AM Wolfram Sang
[off-list ref] wrote:

Hi Prabhakar,

quoted

quoted

Is RPCIF_CMNCR_IO3FV and RPCIF_CMNCR_IO2FV actually documented in your
datasheets? I am asking because I have a patch pending to remove writing
to undocumented locations. So, I was aboout to remove the IO3FV and
IO2FV macros.

Yes they are documented, you should be able to download the HW manual from [1]

Great, then I will keep them!

quoted

quoted

quoted

+     regmap_write(rpc->regmap, RPCIF_PHYADJ2, 0x00008080);
+     regmap_write(rpc->regmap, RPCIF_PHYADJ1, 0x80000024);

Can't we have defines for these magic values? At least in my latest Gen3
documentation, these values are explained.

RZ/G2L manual doesn't explain these bits. Let me refer to R-Car Gen3
and define them as macros.

Seems like we have the best of both worlds then with the documentation
;)

Indeed :)

quoted

quoted

quoted

+     if (rpc->type == RPCIF_RCAR_GEN3) {
+             regmap_write(rpc->regmap, RPCIF_PHYCNT, RPCIF_PHYCNT_STRTIM(7) |
+                          RPCIF_PHYCNT_PHYMEM(hyperflash ? 3 : 0) | 0x260);
+     } else {
+             regmap_read(rpc->regmap, RPCIF_PHYCNT, &dummy);
+             dummy &= ~RPCIF_PHYCNT_PHYMEM_MASK;
+             dummy |= RPCIF_PHYCNT_PHYMEM(hyperflash ? 3 : 0) | 0x260;
+             regmap_write(rpc->regmap, RPCIF_PHYCNT, dummy);

regmap_update_bits?

Im a bit hesitant to use regmap_update_bits() here as some of the bits
are not documented.

Hmm, maybe I should then update the patch avoiding undocumented register
access beforehand? I will download your docs and see what remains and
send that out for you to check. Somewhen later today.

Sounds good?

Fine with me.

Cheers,
Prabhakar

Happy hacking,

   Wolfram