RE: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash
From: Kuldeep Singh <hidden>
Date: 2021-10-01 05:24:29
Also in:
linux-arm-kernel, lkml
Hi Leo,
quoted hunk ↗ jump to hunk
-----Original Message----- From: Li Yang <redacted> Sent: Friday, October 1, 2021 5:34 AM To: Shawn Guo <shawnguo@kernel.org>; Rob Herring [off-list ref]; devicetree@vger.kernel.org; Oleksij Rempel [off-list ref]; linux-arm-kernel@lists.infradead.org; linux- kernel@vger.kernel.org Cc: Leo Li <redacted> Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash Caution: EXT Email Add the missing node for qspi flash. Signed-off-by: Li Yang <redacted> --- arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/arch/arm/boot/dts/ls1021a-qds.dtsb/arch/arm/boot/dts/ls1021a-qds.dts index e2aa569ff404..522e1dc51059 100644--- a/arch/arm/boot/dts/ls1021a-qds.dts +++ b/arch/arm/boot/dts/ls1021a-qds.dts@@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { }; }; +&qspi { + num-cs = <2>;
Please drop "num-cs" property as it is not used by qspi driver.
+ status = "okay";
+
+ qflash0: flash@0 {Can we have flash chip name instead of qflash? There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc. With above fixed, Reviewed-by: Kuldeep Singh <redacted>
+ compatible = "jedec,spi-nor";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ reg = <0>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
+ };
+};
+
&sai2 {
status = "okay";
};
--
2.25.1