Re: [RFC PATCH net-next 01/12] net: mdio: mscc-miim: Fix the mdio controller
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-09-20 11:52:42
Also in:
linux-phy, linux-pm, lkml, netdev
On Mon, Sep 20, 2021 at 11:52:07AM +0200, Horatiu Vultur wrote:
According to the documentation the second resource is optional. But the
blamed commit ignores that and if the resource is not there it just
fails.
This patch reverts that to still allow the second resource to be
optional because other SoC have the some MDIO controller and doesn't
need to second resource.
Fixes: 672a1c394950 ("net: mdio: mscc-miim: Make use of the helper function devm_platform_ioremap_resource()")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Hi Moratiu
The script kiddies might come long and 'fix' this again. Maybe
consider adding devm_platform_ioremap_resource_optional(), following
the pattern of other _optional() API calls. Otherwise add a comment.
Andrew