On Wed 08 Sep 08:29 PDT 2021, Matthias Kaehlcke wrote:

On Wed, Sep 08, 2021 at 02:37:39PM +0530, skakit@codeaurora.org wrote:

quoted

On 2021-09-07 23:46, Matthias Kaehlcke wrote:

quoted

On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote:

quoted

Add pwm support for PM8350C pmic.

Signed-off-by: satya priya <redacted>
---
 arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi

b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index e1b75ae..ecdae55 100644

--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi

@@ -29,6 +29,12 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
+
+		pm8350c_pwm4: pwm {

What does the '4' represent, an internal channel number? It should
probably be omitted if the PM8350 only has a single output PWM
port.

pm8350c has four PWMs, but I think we can drop the '4' here.

Why is only one PWM exposed if the PMIC has for of them? Why number 4
and not one of the others?

The node should represent all 4 channels, which ones the board uses is
captured in how they are bound to other clients - or defines as LEDs by
additional child nodes.

Regards,
Bjorn