On 2021-09-08 01:50, Stephen Boyd wrote:

Quoting satya priya (2021-09-06 03:41:06)

quoted

Add pm8350c compatible and lpg_data to the driver.

Signed-off-by: satya priya <redacted>
---
 drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/leds/rgb/leds-qcom-lpg.c 

b/drivers/leds/rgb/leds-qcom-lpg.c
index 327e81a..6ee80d6 100644

--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c

@@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = 

{
        },
 };

+static const struct lpg_data pm8350c_pwm_data = {
+       .pwm_9bit_mask = BIT(2),
+
+       .num_channels = 1,
+       .channels = (struct lpg_channel_data[]) {

Can this be const struct lpg_channel_data? I think that will move it to
rodata which is only a good thing.

I agree.
@Bjorn, can we make it const struct?

quoted

+               { .base = 0xeb00 },
+       },
+};
+
 static const struct of_device_id lpg_of_table[] = {
        { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data 
},
        { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data 
},
+       { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data 
},
        { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
        { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
        { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },