Re: [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for Cadence XSPI controller
From: Pratyush Yadav <hidden>
Date: 2021-09-03 18:17:33
Also in:
linux-spi, lkml
On 01/09/21 02:37PM, Parshuram Thombare wrote:
quoted hunk ↗ jump to hunk
Add DT binding for Cadence's XSPI controller driver. Signed-off-by: Konrad Kociolek <redacted> Signed-off-by: Jayshri Pawar <redacted> Signed-off-by: Parshuram Thombare <redacted> --- .../devicetree/bindings/spi/cdns,xspi.yaml | 66 ++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/cdns,xspi.yamldiff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml new file mode 100644 index 0000000..e52d6fa --- /dev/null +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml@@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2020-21 Cadence +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/spi/cdns,xspi.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Cadence XSPI Controller + +maintainers: + - Parshuram Thombare <pthombar@cadence.com> + +description: | + The XSPI controller allows SPI protocol communication in + single, dual, quad or octal wire transmission modes for + read/write access to slaves such as SPI-NOR flash.
This needs to be a "subclass" of the spi-controller.yaml binding. allOf: - $ref: spi-controller.yaml#
+
+properties:
+ compatible:
+ const: cdns,xspi-nor
+
+ reg:
+ items:
+ - description: address and length of the controller register set
+ - description: address and length of the Slave DMA data port
+ - description: address and length of the auxiliary registers
+
+ reg-names:
+ items:
+ - const: xspi-iobase
+ - const: xspi-sdmabase
+ - const: xspi-auxbase
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ xspi: spi@a0010000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "cdns,xspi-nor";
+ reg = <0x0 0xa0010000 0x0 0x10000>,
+ <0x0 0xb0000000 0x0 0x10000>,
+ <0x0 0xa0020000 0x0 0x10000>;
+ reg-names = "xspi-iobase", "xspi-sdmabase", "xspi-auxbase";
+ interrupts = <0 90 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-parent = <&gic>;
+ mt35xu512@0 {Node name should be flash@0.
+ compatible = "spi-nor", "micron,mt35xu512";
These compatibles are arbitrary and undocumented. You probably just need "jedec,spi-nor". If you need anything else, you need to justify why. Please run dt_binding_check, it should point this out. See [0].
+ spi-max-frequency = <75000000>;
+ reg = <0>;
+ };
+ mt35xu512@1 {
+ compatible = "spi-nor", "micron,mt35xu512";Same as above.
+ spi-max-frequency = <75000000>; + reg = <1>; + }; + }; -- 2.7.4
[0] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html#testing -- Regards, Pratyush Yadav Texas Instruments Inc.