RE: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI controller

On Fri, Sep 03, 2021 at 08:10:38AM +0000, Parshuram Raju Thombare wrote:

quoted

quoted

quoted

+	master->mode_bits = SPI_3WIRE | SPI_TX_DUAL  | SPI_TX_QUAD  |
+		SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL | SPI_RX_OCTAL

|

quoted

+		SPI_MODE_0  | SPI_MODE_3;

quoted

quoted

I don't see any handling of these in the code?

quoted

This is just to declare controller's capability, so that spi_setup() can modify
spi->mode according to the capability of attached device.

In order for this to work I would expect there to be code in the driver
which configures the controller into the specified mode.

Oh, ok.  That is done at power on reset by the controller in 2 ways.
1. Using device discovery module, controller try to auto detect the valid protocol
    mode by trying to read SFDP signature in various modes.
2. Particular protocol mode can be selected using bootstrap signals.

I think mode_bits need to include protocol mode which is auto detected or
set using bootstrap signals. I will make that change in next version. 

Regards,
Parshuram Thombare