Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
From: Rob Herring <robh@kernel.org>
Date: 2021-08-18 18:33:30
Also in:
linux-arm-kernel, linux-mmc
On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
quoted hunk ↗ jump to hunk
From: Haibo Chen <haibo.chen@nxp.com> Change the pinctrl-names rule to cover all cases. Signed-off-by: Haibo Chen <haibo.chen@nxp.com> --- .../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-)diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index 17086f60f8a3..d324606a4f0a 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml@@ -116,12 +116,21 @@ properties: - const: per pinctrl-names: - minItems: 1 - items: - - const: default - - const: state_100mhz - - const: state_200mhz - - const: sleep + oneOf: + - items: + - const: default + - const: state_100mhz + - const: state_200mhz + - const: sleep + - items: + - const: default + - const: state_100mhz + - const: state_200mhz
You can drop this one and add 'minItems: 3' to the first case.
+ - items: + - const: default + - const: sleep + - items: + - const: default
Similar here too with the prior case. Or use 'minItems: 1' in the first case. That additional allows the 2 entry case, but why isn't that valid? Couldn't a board only support default+state_100mhz? Rob