Re: [PATCH v2] dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-08-12 08:27:24
Also in:
linux-renesas-soc, netdev
Hi Biju, On Tue, Jul 27, 2021 at 2:35 PM Biju Das [off-list ref] wrote:
Document Gigabit Ethernet IP found on RZ/G2L SoC. Gigabit Ethernet Interface includes Ethernet controller (E-MAC), Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory access controller (DMAC) for transferring transmitted Ethernet frames to and received Ethernet frames from respective storage areas in the URAM at high speed. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
quoted hunk ↗ jump to hunk
@@ -145,14 +142,20 @@ allOf: properties: compatible: contains: - const: renesas,etheravb-rcar-gen2 + enum: + - renesas,etheravb-rcar-gen2 + - renesas,rzg2l-gbeth then: properties: interrupts: - maxItems: 1 + minItems: 1 + maxItems: 3 interrupt-names: + minItems: 1 items: - const: mux + - const: int_fil_n + - const: int_arp_ns_n
I'm aware Rob has already applied this, but should the "int_" prefix be dropped? The "_n" suffix is also a bit weird (albeit it matches the documentation). Usually it is used to indicate an active-low signal, but the interrupt is declared in the .dtsi with IRQ_TYPE_LEVEL_HIGH. And the first interrupt is not a mux on RZ/G2L, but called "pif_int_n" (whatever "pif" might mean).
rx-internal-delay-ps: false
else:
properties:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds