Re: [RFC PATCH 3/6] dt-bindings: axi-fan-control: add tacho properties
From: Rob Herring <robh@kernel.org>
Date: 2021-07-12 17:27:02
Also in:
linux-hwmon
On Thu, Jul 08, 2021 at 02:01:08PM +0200, Nuno Sá wrote:
quoted hunk ↗ jump to hunk
Add the bindings for the tacho signal evaluation parameters which depend on the FAN being used. Signed-off-by: Nuno Sá <nuno.sa@analog.com> --- .../bindings/hwmon/adi,axi-fan-control.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml index 6747b870f297..0481eb34d9f1 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml@@ -37,6 +37,18 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 enum: [1, 2, 4] + adi,tacho-25-us: + description: Expected tacho signal when the PWM is at 25%. + + adi,tacho-50-us: + description: Expected tacho signal when the PWM is at 50%. + + adi,tacho-75-us: + description: Expected tacho signal when the PWM is at 75%. + + adi,tacho-100-us: + description: Expected tacho signal when the PWM is at 100%.
This looks like it should be common. But having PWM percents in the property names doesn't scale. This is also a property of the fan, not the fan controller. There's only so many ways a fan can be controlled and I'm going to keep telling folks to make a common fan binding. There's some start to it, but it needs some work. Rob