Re: [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles
From: Heiko Stübner <heiko@sntech.de>
Date: 2021-07-28 14:06:37
Also in:
linux-arm-kernel, linux-gpio, linux-rockchip, lkml
Hi Peter, Am Mittwoch, 28. Juli 2021, 15:55:31 CEST schrieb Peter Geis:
quoted hunk ↗ jump to hunk
The grf and pmugrf phandles are necessary for the pmucru and cru to modify clocks. Add these phandles to permit adjusting the clock rates and muxes. Signed-off-by: Peter Geis <redacted> --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 3 +++ 1 file changed, 3 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index 0905fac0726a..8ba0516eedd8 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi@@ -218,6 +218,8 @@ grf: syscon@fdc60000 { pmucru: clock-controller@fdd00000 { compatible = "rockchip,rk3568-pmucru"; reg = <0x0 0xfdd00000 0x0 0x1000>; + rockchip,grf = <&grf>; + rockchip,pmugrf = <&pmugrf>;
I don't think the pmucru needs both and in fact the mainline clock driver should just reference its specific grf at all, i.e. pmucru -> pmugrf (via the rockchip,grf handle) cru -> grf I've not seen anything breaking this scope so far. Heiko
quoted hunk ↗ jump to hunk
#clock-cells = <1>; #reset-cells = <1>; };@@ -225,6 +227,7 @@ pmucru: clock-controller@fdd00000 { cru: clock-controller@fdd20000 { compatible = "rockchip,rk3568-cru"; reg = <0x0 0xfdd20000 0x0 0x1000>; + rockchip,grf = <&grf>; #clock-cells = <1>; #reset-cells = <1>; };