Re: [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices

From
Arnd Bergmann <arnd@kernel.org>
Date
2021-07-26 16:06:09
Also in
lkml
Reply to
Rob Herring, 2021-07-26
On Mon, Jul 26, 2021 at 4:57 PM Rob Herring [off-list ref] wrote:
On Sun, Jul 25, 2021 at 10:52 PM Viresh Kumar [off-list ref] wrote:
quoted
+    description: |
+      Exactly one node describing the virtio device. The name of the node isn't
+      significant but its phandle can be used to by a user of the virtio device.
+
+  compatible:
+    pattern: "^virtio,[0-9a-f]+$"
DID is only 4 chars? If so, "^virtio,[0-9a-f]{1,4}$"
Any opinion on whether this should have any namespace prefix (or infix, I guess)
after "virtio,"?

I previously suggested making it "virtio,device[0-9a-f]{1,4}$", which would
make it clearer that the following digits are the device ID rather
than something
else we might define in the future. Viresh picked this version because it's
somewhat more consistent with other subsystems.

       Arnd
Thread (22 messages) 22 messages, 6 authors, last reply 2021-09-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help