Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

From
Arnd Bergmann <arnd@kernel.org>
Date
2021-07-26 08:11:54
Also in
linux-i2c, lkml
Reply to
Arnd Bergmann, 2021-07-26
On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann [off-list ref] wrote:
On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar [off-list ref] wrote:
quoted
This patch adds binding for virtio I2C device, it is based on
virtio-device bindings.

Acked-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Too quick, after seeing the same issue in the gpio binding I saw it here too:
+        i2c-virtio {
+            compatible = "virtio,22";
The node name "i2c-virtio" looks wrong. According to
https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml,
this needs to be plain "i2c".

       Arnd
Thread (22 messages) 22 messages, 6 authors, last reply 2021-09-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help