On Tue, 20 Jul 2021 13:34:08 +0000
"Miclaus, Antoniu" [off-list ref] wrote:

Hello Jonathan,

...

quoted

quoted

+
+	enable_reg = FIELD_PREP(ADRF6780_VGA_BUFFER_EN_MSK, dev-
vga_buff_en) |
+			FIELD_PREP(ADRF6780_DETECTOR_EN_MSK, 1) |
+			FIELD_PREP(ADRF6780_LO_BUFFER_EN_MSK, dev-
lo_buff_en) |
+			FIELD_PREP(ADRF6780_IF_MODE_EN_MSK, dev-
if_mode_en) |
+			FIELD_PREP(ADRF6780_IQ_MODE_EN_MSK, dev-
iq_mode_en) |
+			FIELD_PREP(ADRF6780_LO_X2_EN_MSK, dev-
lo_x2_en) |
+			FIELD_PREP(ADRF6780_LO_PPF_EN_MSK, dev-
lo_ppf_en) |
+			FIELD_PREP(ADRF6780_LO_EN_MSK, dev->lo_en) |
+			FIELD_PREP(ADRF6780_UC_BIAS_EN_MSK, dev-
uc_bias_en);  

Here we are probably turning on a bunch of stuff which will result in power
usage.
Would it be sensible to turn it off again in remove path?  (devm managed
should be fine).  

Most of these attributes are enabled by default after device reset.
Taking into account this statement, is it still worth adding a 'custom' remove path?

Perhaps a nice to have if they save power.
Got to love hardware that eats power until you load a driver!

Ah well,

Jonathan