Thread (11 messages) 11 messages, 2 authors, 2021-06-21

Re: [PATCH v4 0/6] Add driver for NVIDIA Tegra30 SoC Thermal sensor

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-06-21 18:25:53
Also in: linux-pm, linux-tegra, lkml

21.06.2021 21:16, Daniel Lezcano пишет:
On 21/06/2021 19:26, Dmitry Osipenko wrote:
quoted
21.06.2021 20:13, Daniel Lezcano пишет:
quoted
Hi Dmitry,

I compiled the your series and got these unresolved.

arm-linux-gnueabi-ld: drivers/thermal/tegra/soctherm-fuse.o: in function
`tegra_calc_shared_calib':
soctherm-fuse.c:(.text+0x60): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld: soctherm-fuse.c:(.text+0xf0): undefined reference
to `tegra_fuse_readl'
arm-linux-gnueabi-ld: drivers/thermal/tegra/soctherm-fuse.o: in function
`tegra_calc_tsensor_calib':
soctherm-fuse.c:(.text+0x144): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld: drivers/thermal/tegra/tegra30-tsensor.o: in
function `tegra_tsensor_fuse_read_spare':
tegra30-tsensor.c:(.text+0x364): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld: drivers/thermal/tegra/tegra30-tsensor.o: in
function `tegra_tsensor_probe':
tegra30-tsensor.c:(.text+0x874): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld:
drivers/thermal/tegra/tegra30-tsensor.o:tegra30-tsensor.c:(.text+0x904):
more undefined references to `tegra_fuse_readl' follow
make[1]: *** [/home/dlezcano/Work/src/linux/Makefile:1196: vmlinux] Error 1
make: *** [/home/dlezcano/Work/src/linux/Makefile:215: __sub-make] Error 2
The missing stub was added by [1]. I guess you could take [2] for the
base since Thierry already sent out PR for 5.14, or we could defer the
"thermal/drivers/tegra: Correct compile-testing of drivers" patch till
the next kernel version. Please choose whatever is easier for you.
I would like to prevent to have more patches floating around. As we are
close the to the merge window, I think we can live with the missing
stubs ATM. But in the future, provide an immutable branch with the
fixes, so we can share it and prevent these issues.
Thank you! There were multiple issues like this during this kernel
release. It's not easy to track all dependencies, I keep forgetting when
and which patches are already applied. Hopefully nobody bisects code
with COMPILE_TEST=y, so this should be a minor issue. Sorry for the
inconvenience.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help