Re: [PATCH v2 1/5] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-06-11 19:48:06
Also in:
linux-arm-kernel, lkml
On Fri, Jun 11, 2021 at 12:27:13AM +0100, Matthew Hagan wrote:
quoted hunk ↗ jump to hunk
Add bindings for the Meraki MX64/MX65 series. Note this patch should be applied on top of "dt-bindings: arm: bcm: add NSP devices to SoCs". Signed-off-by: Matthew Hagan <redacted> --- Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml index 78dfa315f3d0..7d184ba7d180 100644 --- a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml@@ -62,6 +62,12 @@ properties: - enum: - brcm,bcm958625hr - brcm,bcm958625k + - meraki,mx64 + - meraki,mx64-a0 + - meraki,mx64w + - meraki,mx64w-a0 + - meraki,mx65 + - meraki,mx65w - const: brcm,bcm58625 - const: brcm,nsp-- 2.26.3
I think these compatibles describe SoCs, whereas Meraki MX64/MX65 are boards, so this is a miscategorization. Can you not just describe the Northstar Plus SoC that you are using in your compatible string?