Re: [PATCH 6/8] arm64: dts: qcom: pmm8155au_1: Add base dts file
From: Bjorn Andersson <hidden>
Date: 2021-06-11 03:13:43
Also in:
linux-arm-msm, linux-gpio, lkml
On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote:
quoted hunk ↗ jump to hunk
Add base DTS file for pmm8155au_1 along with GPIOs, power-on, rtc and vadc nodes. Cc: Linus Walleij <redacted> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Bjorn Andersson <redacted> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Andy Gross <agross@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: bhupesh.linux@gmail.com Signed-off-by: Bhupesh Sharma <redacted> --- arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 134 ++++++++++++++++++++++ 1 file changed, 134 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/pmm8155au_1.dtsidiff --git a/arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi b/arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi
As we describe our PMICs by including their definition to the top level of the .dts I don't see any alternative to duplicating this as _1 and _2. So let's go with this structure. [..]
+
+&spmi_bus {
+ pmm8155au_1_0: pmic@0 {I don't think you need to give this a label.
+ compatible = "qcom,pmm8155au-1", "qcom,spmi-pmic";
This is a "qcom,pmm8155au", "qcom,spmi-pmic", the labels are used to differentiate the two instances.
+ reg = <0x0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; +
[..]
+
+ pmm8155au_1_gpios: gpio@c000 {
+ compatible = "qcom,pmm8155au-1-gpio";"qcom,pmm8155au-gpio"
+ reg = <0xc000>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+
+ pmic@1 {
+ compatible = "qcom,pmm8155au-1", "qcom,spmi-pmic";"qcom,pmm8155au" Thanks, Bjorn
+ reg = <0x1 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + }; +}; -- 2.31.1