On Mon, 7 Jun 2021 at 17:39, Andy Shevchenko [off-list ref] wrote:

On Mon, Jun 7, 2021 at 2:41 PM Bhupesh Sharma [off-list ref] wrote:

quoted

SA8155p-adp board has two new regulator types - pmm8155au_1 and
pmm8155au_2.

The output power management circuits in these regulators include:
- FTS510 smps,
- HFS510 smps, and
- LDO510 linear regulators

...

quoted

Cc: Linus Walleij <redacted>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <redacted>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Andy Gross <agross@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: bhupesh.linux@gmail.com

Use --cc or similar option when run `git send-email`, no need to
pollute the commit message with these.

It's just a matter of preference IMO. I prefer to use a Cc list
here.

quoted

+static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = {

quoted

+       {},

Comma is not needed in the terminator line.

Hmm.. it's similar to the syntax already used at several places in this file.
See ' struct rpmh_vreg_init_data pm8150l_vreg_data[] ' for example.

Unless there is an obvious issue with it, let's use the same to keep
things similar from a syntax p-o-v.

Thanks,
Bhupesh

quoted

+};

--
With Best Regards,
Andy Shevchenko