Re: [PATCH v23 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller

On Thu, Jun 10, 2021 at 10:56:53AM +0200, Miquel Raynal wrote:

Hi Krzysztof,

Krzysztof Kozlowski [off-list ref] wrote on Thu,
10 Jun 2021 10:48:16 +0200:

quoted

On 10/06/2021 10:20, Miquel Raynal wrote:

quoted

Add a yaml description of this NAND controller which is described as a
subnode of the SMC bus.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
new file mode 100644
index 000000000000..5f126bb9b202
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PL353 NAND Controller device tree bindings
+
+allOf:
+  - $ref: "nand-controller.yaml"
+
+maintainers:
+  - Miquel Raynal <miquel.raynal@bootlin.com>
+  - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
+
+properties:
+  compatible:
+    items:  

I think you can skip the "items" here and leave only "const: foo".

Crap, I missed that one, you're right. I'll wait a bit for Rob's
feedback and eventually fix it when applying or resend (hopefully) only
the NAND bits.

Either way is fine.