Thread (9 messages) read the whole thread 9 messages, 3 authors, 2021-06-07

Re: [PATCH v6 4/5] nvmem: eeprom: at25: export FRAM serial num

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-06-07 09:31:59
Also in: lkml

On Mon, Jun 07, 2021 at 10:26:37AM +0200, Jiri Prchal wrote:
quoted hunk ↗ jump to hunk
This exports serial number of FRAM in sysfs file named "sernum".
Formatted in hex, each byte separated by space.
Example:
$ cat /sys/class/spi_master/spi0/spi0.0/sernum
0000a43644f2ae6c

Signed-off-by: Jiri Prchal <redacted>
---
v2: no change here
v3: resend and added more recipients
v4: resend
v5: reworked up on Greg comments: no spaces in string, sysfs done correctly
v6: no change here
---
 drivers/misc/eeprom/at25.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index 45a486994828..4e4fa8d3ba5d 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -39,6 +39,7 @@ struct at25_data {
 	struct nvmem_config	nvmem_config;
 	struct nvmem_device	*nvmem;
 	int has_sernum;
+	char *sernum;
If this really is only 8 bytes long, just make it an 8 byte array of u8
please.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help