Re: [PATCH v4 1/2] dt-bindings: gpio-mux-input: add documentation
flat view
From: Linus Walleij <hidden>
Date: 2021-06-01 10:11:04
Also in:
linux-gpio, lkml
On Sun, May 30, 2021 at 6:16 PM Mauri Sandberg [off-list ref] wrote:
Add documentation for a general GPIO multiplexer. Signed-off-by: Mauri Sandberg <redacted> Tested-by: Drew Fustini <redacted> Reviewed-by: Drew Fustini <redacted>
Overall very interesting!
quoted hunk ↗ jump to hunk
+ pin-gpios: + description: | + The GPIO pin used as the output from the multiplexer
This is not a good name. "pin" what pin? Choose a descriptive name, like: parent-gpios multiplexed-gpios cascaded-gpios fanout-gpios (My order of preference.) Otherwise these bindings look good. Yours, Linus Walleij