Thread (16 messages) 16 messages, 4 authors, 2021-06-04

Re: [PATCH v4 2/2] gpio: gpio-mux-input: add generic gpio input multiplexer

From: Andy Shevchenko <hidden>
Date: 2021-05-30 19:38:55
Also in: linux-gpio, lkml

On Sun, May 30, 2021 at 10:02 PM Mauri Sandberg [off-list ref] wrote:
On 30.5.2021 21.09, Andy Shevchenko wrote:
quoted
On Sun, May 30, 2021 at 7:16 PM Mauri Sandberg [off-list ref] wrote:
quoted hunk ↗ jump to hunk
quoted
quoted
Reported-by: kernel test robot <redacted>
Is it a fix? Shall we add the Fixes tag?
In the v1 a build bot complained about .owner along these lines:
--- snip ----
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>


cocci warnings: (new ones prefixed by >>)
 >> drivers/gpio/gpio-mux-input.c:138:3-8: No need to set .owner here.
The core will do it.

Please review and possibly fold the followup patch.
--- snip ---
I removed the .owner attribute in v2 as requested but wasn't really sure
whether it was "appropriate"
to add the tag so I put it there anyhow. Technically, this does not fix
any previous commit.
For this kind of thing you may attribute the reporter(s) by mentioning
them in the comment lines / cover letter.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help