Hi Krzysztof,

-----Original Message-----
From: Krzysztof Wilczyński <redacted>
Sent: Monday, May 24, 2021 4:00 PM
To: Thokala, Srikanth <srikanth.thokala@intel.com>
Cc: robh+dt@kernel.org; lorenzo.pieralisi@arm.com; linux-
pci@vger.kernel.org; devicetree@vger.kernel.org;
andriy.shevchenko@linux.intel.com; mgross@linux.intel.com; Raja
Subramanian, Lakshmi Bai [off-list ref];
Sangannavar, Mallikarjunappa [off-list ref]
Subject: Re: [PATCH v9 2/2] PCI: keembay: Add support for Intel Keem Bay

Hi Srikanth,

Everything looks very good!

[...]

quoted

+	ret = devm_add_action_or_reset(dev,
+				       (void(*)(void *))clk_disable_unprepare,
+				       clk);

[...]

Just a small note (no need to change anything) about the above.  Some
drivers add a small wrapper function around the clk_disable_unprepare()
to avoid having to do this case above which is also easier to read as
a result.  But, this is just a matter of whether it's needed (e.g., some
extra steps would be needed to disable clocks, etc.) and personal
preference.

I will make a note of your suggestion, thank you.

Thank you for working on this!

Reviewed-by: Krzysztof Wilczyński <redacted>

Thank you, Krzysztof, for the "Reviewed-by".

Srikanth

	Krzysztof