Thread (7 messages) 7 messages, 2 authors, 2021-05-24

Re: [PATCH v9 2/2] PCI: keembay: Add support for Intel Keem Bay

From: Krzysztof Wilczyński <hidden>
Date: 2021-05-24 10:30:32
Also in: linux-pci

Hi Srikanth,

Everything looks very good!

[...]
+	ret = devm_add_action_or_reset(dev,
+				       (void(*)(void *))clk_disable_unprepare,
+				       clk);
[...]

Just a small note (no need to change anything) about the above.  Some
drivers add a small wrapper function around the clk_disable_unprepare()
to avoid having to do this case above which is also easier to read as
a result.  But, this is just a matter of whether it's needed (e.g., some
extra steps would be needed to disable clocks, etc.) and personal
preference.

Thank you for working on this!

Reviewed-by: Krzysztof Wilczyński <redacted>

	Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help