Re: [PATCH 2/7] PCI: imx6: Initialize ATU unroll offset
From: Rob Herring <robh@kernel.org>
Date: 2021-05-12 20:55:09
Also in:
linux-pci
On Mon, May 10, 2021 at 04:15:04PM +0200, Lucas Stach wrote:
This gets rid of a warning printed when the common code tries to get this address via non-existent DT reg region, before falling back to the default offset.
I guess I caused this... If this is a problem for i.MX, then isn't it a problem for everyone without a separate 'atu' region? I think the right fix is having an optional variant like we do with other resources.
quoted hunk ↗ jump to hunk
Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- drivers/pci/controller/dwc/pci-imx6.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 46b5f070939e..922c14361cd3 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c@@ -1063,6 +1063,8 @@ static int imx6_pcie_probe(struct platform_device *pdev) if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) imx6_pcie->controller_id = 1; + pci->atu_base = pci->dbi_base + DEFAULT_DBI_ATU_OFFSET; + fallthrough; case IMX7D: imx6_pcie->pciephy_reset = devm_reset_control_get_exclusive(dev,-- 2.29.2