Rex-BC Chen [off-list ref] 於 2021年5月26日 週三 上午9:51寫道：

Hello CK,

Thanks for your review.

On Wed, 2021-05-26 at 08:01 +0800, Chun-Kuang Hu wrote:

quoted

Hi, Rex:

Rex-BC Chen [off-list ref] 於 2021年5月25日 週二 下午8:15寫道：

quoted

DPI can sample on falling, rising or both edge.
When DPI sample the data both rising and falling edge.
It can reduce half data io pins.
Use num_output_fmts to determine whether it is dual edge mode.

Signed-off-by: Jitao Shi <redacted>
Signed-off-by: Rex-BC Chen <redacted>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c

b/drivers/gpu/drm/mediatek/mtk_dpi.c
index bea91c81626e..d3b883c97aaf 100644

--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c

@@ -83,6 +83,7 @@ struct mtk_dpi {
        struct pinctrl *pinctrl;
        struct pinctrl_state *pins_gpio;
        struct pinctrl_state *pins_dpi;
+       bool ddr_edge_sel;

I would like to keep output_fmt instead of ddr_edge_sel.
Initialize output_fmt to MEDIA_BUS_FMT_RGB888_1X24 in this patch.

It means that I may initialize output_fmt in probe and set value in
mtk_dpi_bridge_atomic_check() of patch[3/3]?

Yes.

quoted

quoted

        int refcount;
 };