RE: [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy()
From: Ryan Chen <ryan_chen@aspeedtech.com>
Date: 2021-05-24 10:07:32
Also in:
linux-arm-kernel, linux-aspeed, linux-i2c, lkml, openbmc
quoted hunk ↗ jump to hunk
-----Original Message----- From: openbmc [off-list ref] On Behalf Of Quan Nguyen Sent: Wednesday, May 19, 2021 3:50 PM To: Corey Minyard <redacted>; Rob Herring <robh+dt@kernel.org>; Joel Stanley [off-list ref]; Andrew Jeffery [off-list ref]; Brendan Higgins [off-list ref]; Benjamin Herrenschmidt [off-list ref]; Wolfram Sang [off-list ref]; Philipp Zabel [off-list ref]; openipmi-developer@lists.sourceforge.net; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; linux-i2c@vger.kernel.org Cc: Open Source Submission <redacted>; Thang Q . Nguyen [off-list ref]; Phong Vo [off-list ref]; openbmc@lists.ozlabs.org Subject: [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy() Slave i2c device on AST2500 received a lot of slave irq while it is busy processing the response. To handle this case, adds and exports aspeed_set_slave_busy() for controller to temporary stop slave irq while slave is handling the response, and re-enable them again when the response is ready. Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> --- v3: + First introduce in v3 [Quan] drivers/i2c/busses/i2c-aspeed.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index b2e9c8f0ddf7..9926d04831a2 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c@@ -944,6 +944,26 @@ static int aspeed_i2c_init(struct aspeed_i2c_bus*bus, return 0; } +#if IS_ENABLED(CONFIG_I2C_SLAVE) +void aspeed_set_slave_busy(struct i2c_adapter *adap, bool busy) { + struct aspeed_i2c_bus *bus = i2c_get_adapdata(adap); + unsigned long current_mask, flags; + + spin_lock_irqsave(&bus->lock, flags); + + current_mask = readl(bus->base + ASPEED_I2C_INTR_CTRL_REG);
Hello Where the bus->base to be remap?
+ if (busy)
+ current_mask &= ~(ASPEED_I2CD_INTR_RX_DONE |
ASPEED_I2CD_INTR_SLAVE_MATCH);
+ else
+ current_mask |= ASPEED_I2CD_INTR_RX_DONE |
ASPEED_I2CD_INTR_SLAVE_MATCH;
+ writel(current_mask, bus->base + ASPEED_I2C_INTR_CTRL_REG);
+
+ spin_unlock_irqrestore(&bus->lock, flags); }
+EXPORT_SYMBOL_GPL(aspeed_set_slave_busy);
+#endif
+
static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus) {
struct platform_device *pdev = to_platform_device(bus->dev);
--
2.28.0