Re: [PATCH 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025
From: Stephan Gerhold <stephan@gerhold.net>
Date: 2021-05-11 14:38:24
Also in:
linux-iio, lkml
Hi Michał, On Tue, May 11, 2021 at 04:28:47PM +0200, Michał Mirosław wrote:
On Tue, May 11, 2021 at 11:54:06AM +0200, Stephan Gerhold wrote:quoted
KX023-1025 [1] is another accelerometer from Kionix that has lots of additional functionality compared to KXCJK-1013. It combines the motion interrupt functionality from KXCJK with the tap detection from KXTF9, plus a lot more other functionality.When I researched KXTF9 support it occurred to me that the -10xx part is duplicating the information in 'KXyyy' - it seems to be a project number or something. I would suggest to use just 'kx023' prefix for the code and DT but leave the full identification in the comments/description.
There do seem to be two different KXTF9 from Kionix, a KXTF9-4100 [1] and a KXTF9-2050 [2] with separate datasheets. Have you checked if there is a meaningful difference between them? In any case, I think for KX023 there is only KX023-1025, so I suppose I can omit it. I used KX023-1025 as name mostly for consistency, although I did change the convention a bit already since "kionix,kx0231025" was terribly readable. So both the current "kionix,kx023-1025" and "kionix,kx023" would be fine with me, any other opinions? Thanks! Stephan [1]: https://kionixfs.azureedge.net/en/datasheet/KXTF9-4100%20Specifications%20Rev%206.pdf [2]: https://kionixfs.azureedge.net/en/datasheet/KXTF9-2050%20Specifications%20Rev%207.pdf