Re: [PATCH 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025
From: Jonathan Cameron <jic23@kernel.org>
Date: 2021-05-11 14:09:14
Also in:
linux-iio, lkml
On Tue, 11 May 2021 12:44:23 +0200 Hans de Goede [off-list ref] wrote:
Hi, On 5/11/21 11:54 AM, Stephan Gerhold wrote:quoted
KX023-1025 [1] is another accelerometer from Kionix that has lots of additional functionality compared to KXCJK-1013. It combines the motion interrupt functionality from KXCJK with the tap detection from KXTF9, plus a lot more other functionality. This patch set does not add support for any of the extra functionality, but makes basic functionality work with the existing kxcjk-1013 driver. At first, the register map for the KX023-1025 seems quite different from the other accelerometers supported by the kxcjk-1013. However, it turns out that at least most of the register bits still mean the same for KX023-1025. This patch set refactors the kxcjk-1013 driver a little bit to get the register addresses from a chip-specific struct. The register bits can be re-used for all the different chips. The KX023-1025 is used in several smartphones from Huawei. I tested these changes on a Huawei Ascend G7, someone else reported they also work fine on the Huawei Honor 5X (codename "kiwi"). [1]: https://kionixfs.azureedge.net/en/datasheet/KX023-1025%20Specifications%20Rev%2012.0.pdf Stephan Gerhold (3): dt-bindings: iio: kionix,kxcjk1013: Document kionix,kx023-1025 iio: accel: kxcjk-1013: Refactor configuration registers into struct iio: accel: kxcjk-1013: Add support for KX023-1025Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede <redacted>
Other than those things 0-day found which would be good to tidy up for a v2 looks good to me. Thanks, Jonathan
for the series. Regards, Hans