On Thu, Mar 4, 2021 at 2:08 AM Geert Uytterhoeven [off-list ref] wrote:

Hi Adam,

On Wed, Feb 24, 2021 at 12:52 PM Adam Ford [off-list ref] wrote:

quoted

For devices that use a programmable clock for the AVB reference clock,
the driver may need to enable them.  Add code to find the optional clock
and enable it when available.

Signed-off-by: Adam Ford <redacted>

Thanks for your patch!

quoted

--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c

@@ -2148,6 +2148,13 @@ static int ravb_probe(struct platform_device *pdev)
                goto out_release;
        }

+       priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk");
+       if (IS_ERR(priv->refclk)) {
+               error = PTR_ERR(priv->refclk);
+               goto out_release;
+       }
+       clk_prepare_enable(priv->refclk);
+

Shouldn't the reference clock be disabled in case of any failure below?

I'll generate a V4.

Should I just regenerate this patch since it seems like the rest are
OK, or should I regenerate the whole series?

adam

quoted

        ndev->max_mtu = 2048 - (ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN);
        ndev->min_mtu = ETH_MIN_MTU;

@@ -2260,6 +2267,9 @@ static int ravb_remove(struct platform_device *pdev)
        if (priv->chip_id != RCAR_GEN2)
                ravb_ptp_stop(ndev);

+       if (priv->refclk)
+               clk_disable_unprepare(priv->refclk);
+
        dma_free_coherent(ndev->dev.parent, priv->desc_bat_size, priv->desc_bat,
                          priv->desc_bat_dma);
        /* Set reset mode */

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds