Thread (20 messages) 20 messages, 4 authors, 2021-04-19

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-02-24 14:56:58
Also in: linux-renesas-soc, lkml, netdev

quoted hunk ↗ jump to hunk
@@ -2260,6 +2267,9 @@ static int ravb_remove(struct platform_device *pdev)
 	if (priv->chip_id != RCAR_GEN2)
 		ravb_ptp_stop(ndev);
 
+	if (priv->refclk)
+		clk_disable_unprepare(priv->refclk);
+
Hi Adam

You don't need the if (). The clk API is happy with a NULL pointer and
will do the right thing. Otherwise:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help